Skip to content

Aseem Phase 2: lesson list dark-mode - #4579

Closed
aseemdeshmukh wants to merge 22 commits into
developmentfrom
aseem-lessonlist-darkmode
Closed

Aseem Phase 2: lesson list dark-mode#4579
aseemdeshmukh wants to merge 22 commits into
developmentfrom
aseem-lessonlist-darkmode

Conversation

@aseemdeshmukh

Copy link
Copy Markdown
Contributor

Description

1
2

Main changes explained:

  • Updated file LessonCard.jsx
  • Updated file LessonCard.module.css
  • Updated file LessonListForm.jsx
  • Updated file LessonListForm.module.css

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to http://localhost:3000/bmdashboard/lessonlist
  6. For Dark mode, verify if the entire Lesson List page—including all components, cards, and controls—renders in consistent dark styling.

Screenshots or videos of changes:

lessonlistDemo.mp4

Note:

This PR is dedicated only for dark mode compatibility. No old/new functionalities has been modified/created.

@netlify

netlify Bot commented Dec 19, 2025

Copy link
Copy Markdown

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 2e3ac00
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6990bef21683bb0008f7dbda
😎 Deploy Preview https://deploy-preview-4579--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

Copy link
Copy Markdown

@aseemdeshmukh aseemdeshmukh added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Dec 19, 2025

@rohanrastogi311 rohanrastogi311 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked through all affected parts of the site with dark mode. Everything looks great. Well done.

PR4579 Screenshot

@Anusha-Gali Anusha-Gali left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Aseem,

I have reviewed your PR locally and as you can see in the below video - the tags in textboxes do not adapt to dark mode and the expand all button does not work - though i understand functionality is not a part of the PR but unless it work we cannot see if any content below it is adapted to dark mode.

4579.mov

@aseemdeshmukh aseemdeshmukh changed the title Phase 2: Aseem lesson list dark-mode Aseem Phase 2: lesson list dark-mode Feb 5, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@aseemdeshmukh

Copy link
Copy Markdown
Contributor Author

Hi Aseem,

I have reviewed your PR locally and as you can see in the below video - the tags in textboxes do not adapt to dark mode and the expand all button does not work - though i understand functionality is not a part of the PR but unless it work we cannot see if any content below it is adapted to dark mode.

4579.mov

Hi Anusha,
Thank you for testing this PR. I will look into the tags compatibility in dark mode for the text boxes and will update once done.
As you mentioned, this PR focuses mainly on the UI side of the webpage specifically the dark mode styling.
The error of "Something went wrong" after clicking the button was existing before I started working on the task and another task can be created specifically for this error to maintain the integrity of the current PR and to not confuse anyone else going through the current PR.

@aseemdeshmukh

Copy link
Copy Markdown
Contributor Author

Created a new PR #5372 and closing the current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants