Work around for servers that send unquoted algorithm information#2
Open
akurz wants to merge 1 commit intoOne-com:masterfrom
Open
Work around for servers that send unquoted algorithm information#2akurz wants to merge 1 commit intoOne-com:masterfrom
akurz wants to merge 1 commit intoOne-com:masterfrom
Conversation
|
I honestly don't think the servers are misbehaving. So ... yeah... that's a bug. But it's a bug caused by the rather simple parsing of the WWW-Authenticate header, using strings.Split() and strings.Contains() on '"', which you patch then build upon also doing it for '=' ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider to merge this pull request as a workaround for misbehaving(?) servers that don't quote the algorithm header information.
thx & cheers,
Andreas