Skip to content

Fail cleanly when an option is missing its value #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SNO7E-G wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fail cleanly when an option is missing its value #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ptc-cli.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3198,6 +3198,18 @@ main() {

# Argument parsing
while [[ $# -gt 0 ]]; do
# A value-taking option with no value left would read an unbound "$2"
# and, under `set -u`, abort with a raw bash error. Fail cleanly instead.
# (The "--opt=value" forms carry their value in $1 and are exempt.)
case "$1" in
-s|--source-locale|-p|--patterns|-c|--config-file|-t|--file-tag-name|-d|--project-dir|--api-url|--api-token|--monitor-interval|--monitor-max-attempts|--action)
if [[ $# -lt 2 ]]; then
log_error "Option '$1' requires a value."
echo "Use --help for help"
exit 1
fi
;;
esac
case $1 in
-s|--source-locale)
PTC_SOURCE_LOCALE="$2"
Expand Down