Simplify handling of dead connections to make it more robust.#243
Open
altruizine wants to merge 1 commit intoOfflineIMAP:masterfrom
Open
Simplify handling of dead connections to make it more robust.#243altruizine wants to merge 1 commit intoOfflineIMAP:masterfrom
altruizine wants to merge 1 commit intoOfflineIMAP:masterfrom
Conversation
IMAPServer.acquireconnection: If connection turns out to be dead, release and recursively reacquire it. It turns out that the fix in 680d874 was not sufficient and perhaps a bit over-engineered: It resulted in prolonged unhealthy sockets. This new fix uses the same basic idea (call acquireconnection recursively to return a healthy socket) but simply and unceremoniously calls releaseconnection on the unhealthy one. How, unhealthy sockets are detected and fixed quickly. Signed-off-by: Michael Hohmuth <hohmuth@sax.de>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
References
Additional information
This issue surfaced with the fix in #241.