Skip to content

Update to comply with secure registry - #513

Open
millerds wants to merge 5 commits into
masterfrom
user/millerds/registry-compliance
Open

Update to comply with secure registry#513
millerds wants to merge 5 commits into
masterfrom
user/millerds/registry-compliance

Conversation

@millerds

Copy link
Copy Markdown
Contributor

Change Description:
Update .npmrc to use a compliant registry feed
Also include some package updates.

  1. Do these changes impact any npm scripts commands (in package.json)? (e.g., running 'npm run start')
    No.

  2. Do these changes impact VS Code debugging options (launch.json)?
    No.

  3. Do these changes impact template output? (e.g., add/remove file, update file location, update file contents)
    No.

  4. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)
    No.

If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct

Validation/testing performed:
Ran automated tests

@millerds

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project to comply with a secure/compliant npm registry feed, including documentation updates and dependency refreshes, plus a small E2E test helper refactor away from the deprecated request package.

Changes:

  • Switch .npmrc to the OfficeDev Azure Artifacts registry and enable always-auth.
  • Update several dev dependencies (Office add-in tooling, webpack-dev-server, copy-webpack-plugin) and remove request.
  • Refactor E2E debugger attachment helper to use fetch instead of request, and document registry authentication steps in README.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
test/end-to-end/src/debugger-websocket.ts Replaces request with fetch and makes URL discovery awaitable in the reconnect flow.
README.md Adds npm registry authentication instructions for the new feed.
package.json Updates devDependency versions and removes request.
.npmrc Points npm to the compliant OfficeDev registry and enables always-auth.
Comments suppressed due to low confidence (1)

test/end-to-end/src/debugger-websocket.ts:33

  • If wsUrl is still undefined after the retry loop (e.g., the debugger never becomes available), the function continues and constructs new WebSocket(wsUrl), which will throw. It should bail out when retries are exhausted.
  while (!wsUrl && reconnectTry < limitOfReconnectTries) {
    console.log(`Attaching debugger to '${jsonUrl}'...`);
    await findUrl(jsonUrl);
    reconnectTry++;
    await sleep(1000);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .npmrc Outdated
Comment thread test/end-to-end/src/debugger-websocket.ts Outdated
Comment thread README.md

Copilot AI commented Jul 27, 2026

Copy link
Copy Markdown

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflict in package-lock.json. The conflict was due to a hono version bump on master — I kept the PR branch version (4.12.31) resolved from the OfficeDev registry (office.pkgs.visualstudio.com), which is consistent with the registry compliance goal of this PR.

millerds and others added 2 commits July 27, 2026 10:19
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants