Refactor openInitializeChainDb for Execution/Consensus split #4169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4169 +/- ##
==========================================
- Coverage 33.41% 33.11% -0.31%
==========================================
Files 461 462 +1
Lines 55901 55976 +75
==========================================
- Hits 18681 18534 -147
- Misses 33921 34179 +258
+ Partials 3299 3263 -36 |
❌ 9 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
bragaigor
force-pushed
the
braga/refactor-openInitialzeChainDb
branch
from
4ac62dd to
1826ff4
Compare
bragaigor
force-pushed
the
braga/refactor-openInitialzeChainDb
branch
from
0bab452 to
7b16439
Compare
bragaigor
commented
Dec 24, 2025
cmd/nitro/init.go
Outdated
Comment on lines
634
to
641
| if chainConfig == nil { | ||
| chainConfig, err = getChainConfig(config, initDataReader, executionDB) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| } | ||
|
|
||
| parsedInitMessage, err := getConsensusParsedInitMsg(ctx, config, chainId, l1Client, rollupAddrs, chainConfig) |
Contributor
Author
There was a problem hiding this comment.
This part in particular, might different a bit in logic from the current chainConfig lifecycle which is as follows:
readOnlyDB, err := stack.OpenDatabaseWithOptions
if err == nil {
chainConfig := gethexec.TryReadStoredChainConfig(readOnlyDB)
if chainConfig != nil {
validateBlockChain(l2BlockChain, chainConfig)
return rebuildLocalWasm(... l2BlockChain, executionDB, ...)
}
}
var chainConfig *params.ChainConfig
if config.Init.GenesisJsonFile != "" {
chainConfig = gen.Config
}
if initDataReader == nil {
chainConfig = gethexec.TryReadStoredChainConfig(executionDB)
if chainConfig == nil { return error }
else {
if chainConfig == nil {
chainConfig, err = chaininfo.GetChainConfig(...)
if err != nil {return err}
}
}
validateBlockChain(l2BlockChain, chainConfig)
return rebuildLocalWasm(... l2BlockChain, executionDB, ...)And now is:
..., chainConfig, err := openExistingExecutionDB
// if evaluated to true then chainConfig is also nil
if executionDB == nil {
..., chainConfig, ..., err = getInit(config)
if chainConfig == nil {
chainConfig, err = getChainConfig(config, initDataReader, executionDB)
}
}
if chainConfig == nil { return error }
validateBlockChain(l2BlockChain, chainConfig)
return rebuildLocalWasm(... l2BlockChain, executionDB, ...)
diegoximenes
requested changes
Dec 29, 2025
Contributor
diegoximenes
left a comment
diegoximenes
left a comment
There was a problem hiding this comment.
How about checking if it is easy to extend a bold test so it can test getGenesisAssertionCreationInfo and validateGenesisAssertion?
If it is easy then the test can be implemented 🙂
| Require(t, err) | ||
| } | ||
|
|
||
| func TestOpenDownloadedExecutionDB(t *testing.T) { |
Contributor
There was a problem hiding this comment.
You can also create a test for openExistingExecutionDB.
You can move openExistingExecutionDB out of the main package, so it is able to be imported by system test.
You can create a system test that starts a L2 chain, create some blocks, stop the chain, and then calls openExistingExecutionDB.
Something similar to TestDatabaseConversion.
Then you can check if it is properly able to read executionDB, reading a block hash with rawdb.ReadCanonicalHash for example.
Contributor
Author
There was a problem hiding this comment.
That would be nice so I created ticket NIT-4268 to do on another PR as I thought it would make things look more organized if done separately. But please let me know if you prefer this to be done in this PR.
Member
pmikolajczyk41
left a comment
pmikolajczyk41
left a comment
There was a problem hiding this comment.
throwing two secondary comments for now
Today openInitializeChainDb has procedures related to both Execution and Consensus components. So we split them into target functions related specifically to either Execution and Consensus. Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Add checkDBDir tests Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
- Create new config package to expose and organize init and config nitro functionality. - Add new system_tests for openExistingExecutionDB and getConsensusParsedInitMsg Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
bragaigor
force-pushed
the
braga/refactor-openInitialzeChainDb
branch
from
416a75e to
67f56ab
Compare
bragaigor
commented
Dec 31, 2025
Contributor
Author
There was a problem hiding this comment.
@diegoximenes these are the system_tests I included for openExistingExecutionDB and getConsensusParsedInitMsg. As a result of exposing those functions I created config package under cmd/nitro; not sure if config is too generic of a name. Still looking at how to test getGenesisAssertionCreationInfo without introducing too much code, will update after trying some more.
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
openInitializeChainDbhas procedures related to both Execution and Consensus components. So we split them into target functions related specifically to either Execution and Consensus.Now
openInitializeChainDbcan be thought of as:closes NIT-4199
closes NIT-4268