Repository navigation
Update Node.js to fix the Brotli security issue (CVE-2026-111497) - #3532
Merged
Merged
Conversation
|
Pull request environment is available at https://stoctodocspr3532.z22.web.core.windows.net/. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Node.js to a fixed release for the Brotli security issue CVE-2026-111497 ("Node2Shell"). This matches the change already made to the other Astro microsites (blog-new, devops, Handbook, integrations).
The fixed Node releases are 22.23.4, 24.22.1 and 26.12.1. Node 20, 23, 25 and earlier won't get a fix.
Changes
.github/versions.env:NODE_VERSIONgoes from22to22.23.4. The PR workflows (branch-markdown.yml,branch-spellcheck.yml) read this value. With only22,setup-nodecould pick an older 22.x already cached on the runner..nvmrc(new): pins22.23.4, the same version the shared deploy build uses, so local development matches CI.package.json:engines.nodegoes from>=18.14.1to^22.23.4 || ^24.22.1 || >=26.12.1, so vulnerable and end-of-life versions no longer meet the requirement. Thepnpmengine is unchanged.Verification
pnpm installon Node 22.23.4:pnpm-lock.yamlis unchanged.pnpm buildon Node 22.23.4: passes (3,135 pages).mainstarts a deploy build. Its "Setup Node" step should shownode: v22.23.4.