ci: stop Update README corrupting the plugin version lines (unblocks the 1.0.0 release) - #14
Open
NickJosevski wants to merge 1 commit into
Open
ci: stop Update README corrupting the plugin version lines (unblocks the 1.0.0 release)#14NickJosevski wants to merge 1 commit into
NickJosevski wants to merge 1 commit into
Conversation
Releasing 1.0.0 (#13) is blocked by a failing Lint check, and the cause is this workflow, not the release. The sed used `.*` after `create-release#`, which also consumed the trailing colon of the YAML mapping key: - OctopusDeploy/create-release#v0.1.1: -> - OctopusDeploy/create-release#v1.0.0 Every example then had an unkeyed sequence entry followed by indented mappings, so the plugin linter fails with "bad indentation of a sequence entry". The bug has been here since the workflow was added; it simply never ran, because there has been no release since 2022. The replacement matches only the version and always re-emits the colon, so it is also self-healing on a README a previous run already mangled. It still leaves other plugins' refs (e.g. octopus-login#) alone. Also adds a concurrency group. release-please pushed to the release branch three times in quick succession, and the three resulting runs raced on git push; one failed with "! [rejected] ... (fetch first)". Verified by running the new sed over main's README and linting the result: 7 examples valid, no YAML errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
force-pushed
the
nj/fix-update-readme
branch
from
August 22, 2026 02:07
615c24d to
9bbe579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The 1.0.0 release PR (#13) has a failing Lint check, so the release is blocked. The cause is this workflow, not the release.
Update READMErewrites the plugin version in the README's examples with:.*also consumes the trailing colon of the YAML mapping key:Every example then becomes an unkeyed sequence entry followed by indented mappings, and the plugin linter rejects it:
This bug has been present since the workflow was added. It simply never ran — there has been no release since 2022, and
update-readmeonly triggers on pushes torelease-please--**.The fix
Matches only the version and always re-emits the colon. Two useful properties:
create-release#, so other plugins' refs are untouched. The README now referencesOctopusDeploy/octopus-login#v1.0.0, which must keep its own version.Also: a push race
release-please pushed to the release branch three times in quick succession, so three
Update READMEruns started together and raced ongit push. One failed:Two of the three succeeded so the outcome was fine, but it's luck. Added a
concurrencygroup keyed on the ref, withcancel-in-progress: falseso the last push still gets applied rather than cancelled.Verification
Ran the new sed over
main's README and linted the result:Also confirmed the old sed reproduces #13's exact failure, and that the new one repairs #13's already-corrupted README.
After this merges
release-please will refresh #13's branch,
Update READMEwill re-run with the fixed sed, and Lint should go green — unblocking the 1.0.0 release. Worth a check rather than an assumption, since that workflow can only be exercised for real on a release branch.🤖 Generated with Claude Code