Repository navigation
testutil/genchangelog: credit PR authors in release notes - #4781
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Bot-authored PR logins are currently omitted from attribution and the Contributors section.
0 open findings
What changed in this PR
Updates changelog generation to credit GitHub PR authors and list contributors, including issue-linked PR authors.
Changes:
- Resolves PR authors with graceful lookup failures.
- Adds author mentions to release notes.
- Adds a sorted Contributors section and tests.
| File | Description |
|---|---|
testutil/genchangelog/template.md |
Renders author mentions and contributors. |
testutil/genchangelog/main.go |
Resolves authors and builds contributor data. |
testutil/genchangelog/main_internal_test.go |
Tests attribution behavior. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4781 +/- ##
==========================================
+ Coverage 65.65% 65.71% +0.05%
==========================================
Files 246 246
Lines 30171 30171
==========================================
+ Hits 19809 19827 +18
+ Misses 10361 10343 -18
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
OisinKyne
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve each PR's GitHub login and append
by @loginto the What's Changed lines, plus a Contributors section listing every author in the range, including authors of PRs linked to issues. GitHub renders the avatars of @mentioned users under a release, which our notes lost when we moved off GitHub's generated format after v1.3.0. A failed lookup only drops that mention instead of failing the release job; the job already exportsGITHUB_TOKEN, so lookups are authenticated.category: misc
ticket: none