Complete source attachments and normalize repository files - #184
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four source attachments omitted their Java 9 module descriptors. Add them under
META-INF/versions/9after compilation/resource copying, and use the non-forking source goal. Packaged-consumer preparation now checks every main-source file, the descriptors, and Javadoc indexes; a negative guard proves a missing descriptor fails.Normalize repository text/XML policy, the lone CRLF POM and erroneous executable bit, redundant target ignores, and the unused root manifest. Update the ESAPI fixture's obsolete justification-property spelling while leaving dangerous methods disabled. No Java implementations or binary fixtures change. Existing dependencies remain because none were proven unused beyond the optional-app removals in #93. Preserve the exception's existing derived serialization identity; no
serialVersionUIDchange is needed. #137 already owns BSNs.Validation: JDK 17 clean verify (2,178 unit tests, eight existing integration tests, both packaged JSP engines), 17 artifact guards, 34-file taglib parity, prepared classpath/JPMS/OSGi consumers on Java 17, and focused ESAPI tests passed. Sol review found no actionable findings. Astra final review also found no actionable findings; all 26 checks passed on
c94a5d180f15bb02fb021d98938ada248fa812f3. Neither model review is independent maintainer approval.Closes #123. Batch 04 progress for #169.