Update experimental models to build with new tolerance settings#352
Open
pelesh wants to merge 1 commit intoSteven-Roberts/fixed-step-IDAfrom
Open
Update experimental models to build with new tolerance settings#352pelesh wants to merge 1 commit intoSteven-Roberts/fixed-step-IDAfrom
pelesh wants to merge 1 commit intoSteven-Roberts/fixed-step-IDAfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update experimental power flow models and related examples to build with the new method for setting tolerances.
Proposed changes
Add method
setAbsoluteTolerance(RealT)to component modelsGenerator2,Generator4Governor, andGenerator4Param.Update related examples to set solver tolerances and max number of steps as:
Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Experimental examples are not expected to run successfully. This PR will just enable building these examples correctly in the target branch. For these examples to run correctly issue in SUNDIALS needs to be addressed.