[DAPS-1906-2] - feat: enable building of core integration tests

[JoshuaSBrown]

Description

Part 2 adds integration testing to core server as part of CI.

Summary by Sourcery

Enable core integration tests in the Docker-based build and simplify mock test executable linking.

Build:

• Enable integration tests in the core Docker build configuration.

Tests:

• Adjust mock liveness test executables to link only against Boost and common libraries, dropping GSSAPI and Globus Common dependencies.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enables building and running core server integration tests in CI by turning on the integration test CMake option in the core Docker image and simplifying link dependencies for mock liveness test binaries.

Sequence diagram for CI running core integration tests

sequenceDiagram
    actor Developer
    participant Repo as Git_Repository
    participant CI as CI_System
    participant Docker as Core_Docker_Builder
    participant CMake as CMake_Config
    participant Tests as Integration_Tests

    Developer->>Repo: Push changes
    Repo-->>CI: Trigger CI pipeline

    CI->>Docker: Build core Docker image
    Docker->>CMake: Configure
    CMake-->>Docker: Configure with ENABLE_INTEGRATION_TESTS=True
    Docker-->>CI: Built image with integration tests

    CI->>Docker: Run test stage in image
    Docker->>Tests: Execute core integration tests
    Tests-->>Docker: Test results
    Docker-->>CI: Propagate test results

Loading

File-Level Changes

Change	Details	Files
Enable integration tests in the core server Docker build configuration.	Flip CMake configuration flag ENABLE_INTEGRATION_TESTS from False to True in the core Docker build step Keep existing unit test configuration and build/install steps unchanged	core/docker/Dockerfile
Adjust mock liveness test binaries to link only against required libraries.	Remove GSSAPI and Globus Common libraries from mock_liveness_* target_link_libraries Retain linkage to Boost and common library for mock liveness test executables Keep conditional BOOST_TEST_DYN_LINK definition logic intact for shared builds	tests/mock/CMakeLists.txt

Possibly linked issues

• #[Feature] - CI, Test, Core, add integration and core unit testing to CI: PR turns on core integration tests in CI, directly addressing the issue’s CI test coverage gap.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider making ENABLE_INTEGRATION_TESTS configurable (e.g., via a Docker build arg or environment variable) instead of hardcoding it to True, so the same Dockerfile can be used for both CI and lighter local builds.
• Double-check that all the mock_liveness_* targets truly no longer rely on ${DATAFED_GSSAPI_LIBRARIES} or ${DATAFED_GLOBUS_COMMON_LIBRARIES} at link time; if this is intentional, it might help to add a brief comment in tests/mock/CMakeLists.txt explaining why these dependencies were removed for future maintainers.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider making `ENABLE_INTEGRATION_TESTS` configurable (e.g., via a Docker build arg or environment variable) instead of hardcoding it to `True`, so the same Dockerfile can be used for both CI and lighter local builds.
- Double-check that all the `mock_liveness_*` targets truly no longer rely on `${DATAFED_GSSAPI_LIBRARIES}` or `${DATAFED_GLOBUS_COMMON_LIBRARIES}` at link time; if this is intentional, it might help to add a brief comment in `tests/mock/CMakeLists.txt` explaining why these dependencies were removed for future maintainers.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}