Skip to content

Record that §14's field order is confirmed (draft-protocol#50) #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
OR13 wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Record that §14's field order is confirmed (draft-protocol#50) #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44f99f6
Why: §9.1 is the last protocol operation with a peer to check it agai…
OR13 Jul 30, 2026
8be5e09
Why: the draft moved on 2026-07-28 and the peer did not, so five find…
OR13 Jul 30, 2026
4708e77
Why: the P-256 suite was the last row a peer could verify and wasn't,…
OR13 Jul 30, 2026
80914ee
Why: the draft's editor answered #50, and the answer is that our read…
OR13 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,18 @@ jobs:
- name: The checks must pass against freshly generated vectors
run: cargo run -p kt-interop --bin kt-interop-report -- --vectors interop/vectors --out "$RUNNER_TEMP/fresh"

# search.json and monitor.json are excluded because they cannot be reproducible: both
# are served by a live log that stamps wall-clock times and draws random commitment
# openings. See interop/README.md. Every other file must regenerate to the same bytes,
# Four files are excluded because they cannot be reproducible. search.json, monitor.json
# and update.json come from a live log that stamps wall-clock times and draws random
# commitment openings; tree-head-p256.json carries ECDSA signatures, and Go's crypto/ecdsa
# draws a nonce per signature. See interop/README.md. Every other file must regenerate to
# the same bytes,
# so an upstream bump that changes behaviour shows up as a diff rather than a silent
# pass — and the two exceptions are covered by the fresh-generation run above, which
# is a stronger check for them than a diff would be.
- name: Vectors must be reproducible
run: |
git diff --exit-code -- interop/vectors \
':(exclude)interop/vectors/search.json' \
':(exclude)interop/vectors/monitor.json'
':(exclude)interop/vectors/monitor.json' \
':(exclude)interop/vectors/update.json' \
':(exclude)interop/vectors/tree-head-p256.json'
198 changes: 198 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/kt-crypto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ curve25519-dalek = { version = "5.0.0", default-features = false, features = ["a
ed25519-dalek = { version = "3.0.0", default-features = false, features = ["alloc"] }
hmac = { version = "0.13.0", default-features = false }
kt-wire.workspace = true
p256 = { version = "0.14.0", default-features = false, features = ["arithmetic", "alloc", "ecdsa"] }
sha2 = { version = "0.11.0", default-features = false }

[lints]
Expand Down
Loading
Loading