fix(tests): use correct env var name for PostgreSQL server#782
Open
haoyu-haoyu wants to merge 1 commit intoOHDSI:mainfrom
Open
fix(tests): use correct env var name for PostgreSQL server#782haoyu-haoyu wants to merge 1 commit intoOHDSI:mainfrom
haoyu-haoyu wants to merge 1 commit intoOHDSI:mainfrom
Conversation
The skip guard checks CDM5_POSTGRESQL_SERVER, but the actual connection details use CDMDDLBASE_POSTGRESQL_SERVER. This causes tests to run (not skip) in environments where CDM5_POSTGRESQL_SERVER is set but CDMDDLBASE_POSTGRESQL_SERVER is not, leading to failures. Closes OHDSI#719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skip guard in
setup.Randtest-executeDdl.RchecksCDM5_POSTGRESQL_SERVER, but all actual connection details useCDMDDLBASE_POSTGRESQL_SERVER. This mismatch means tests try to run in environments whereCDM5_POSTGRESQL_SERVERis set (common in OHDSI CI) butCDMDDLBASE_POSTGRESQL_SERVERis not, leading to failures instead of a clean skip.Changed both occurrences to
CDMDDLBASE_POSTGRESQL_SERVERso the guard matches the actual variable thatgetConnectionDetails()reads.Closes #719