Skip to content

[18.0][MIG] web font size report layout: Migration to 18.0 - #3661

Open
DorianMAG wants to merge 9 commits into
OCA:18.0from
DorianMAG:18.0-mig-web_font_size_report_layout
Open

[18.0][MIG] web font size report layout: Migration to 18.0#3661
DorianMAG wants to merge 9 commits into
OCA:18.0from
DorianMAG:18.0-mig-web_font_size_report_layout

Conversation

@DorianMAG

Copy link
Copy Markdown

Based on PR #3389

@flotho flotho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully tested locally

@rrebollo rrebollo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

body, .o_report_layout, .page,
.o_report_layout *, .page *,
table, td, th, p, li, span, div {
font-size: <t t-esc="fs" />pt !important;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: <t t-esc="fs" />pt !important;
font-size: <t t-out="fs" />pt !important;

body, .o_report_layout, .page,
.o_report_layout *, .page *,
table, td, th, p, li, span, div {
font-size: <t t-esc="fs" />pt !important;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: <t t-esc="fs" />pt !important;
font-size: <t t-out="fs" />pt !important;

body, .o_report_layout, .page,
.o_report_layout *, .page *,
table, td, th, p, li, span, div {
font-size: <t t-esc="fs" />pt !important;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: <t t-esc="fs" />pt !important;
font-size: <t t-out="fs" />pt !important;

body, .o_report_layout, .page,
.o_report_layout *, .page *,
table, td, th, p, li, span, div {
font-size: <t t-esc="fs" />pt !important;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: <t t-esc="fs" />pt !important;
font-size: <t t-out="fs" />pt !important;

body, .o_report_layout, .page,
.o_report_layout *, .page *,
table, td, th, p, li, span, div {
font-size: <t t-esc="fs" />pt !important;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: <t t-esc="fs" />pt !important;
font-size: <t t-out="fs" />pt !important;

body, .o_report_layout, .page,
.o_report_layout *, .page *,
table, td, th, p, li, span, div {
font-size: <t t-esc="fs" />pt !important;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: <t t-esc="fs" />pt !important;
font-size: <t t-out="fs" />pt !important;

@DorianMAG
DorianMAG force-pushed the 18.0-mig-web_font_size_report_layout branch from 216a753 to 50466df Compare September 9, 2026 14:55
@DorianMAG

Copy link
Copy Markdown
Author

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

Thx for the review.
I applied your recommendation.
Regards

@DorianMAG
DorianMAG requested a review from rrebollo September 9, 2026 15:25

@rrebollo rrebollo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

@DorianMAG

Copy link
Copy Markdown
Author

ping
@ivs-cetmix
@bealdav
@edescalona
@adasatorres
Could you do a code review plz?
Regards

@JulienMartinez JulienMartinez left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just make title:- [18.0][MIG] web_font_size_report_layout: Migration to 18.0

@adasatorres-tecnativa adasatorres-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DorianMAG DorianMAG changed the title [18.0][MIG]web font size report layout: Migration to 18.0 [18.0][MIG] web font size report layout: Migration to 18.0 Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants