[ADD] web_responsive_company_color#3428
Conversation
SirPyTech
force-pushed
the
18.0-mig-web_responsive_company_color
branch
from
4881ffa to
b3153e0
Compare
SirPyTech
force-pushed
the
18.0-mig-web_responsive_company_color
branch
from
b3153e0 to
112fed8
Compare
anusriNPS
left a comment
anusriNPS
left a comment
There was a problem hiding this comment.
Code and Functional Review: LGTM
SirPyTech
force-pushed
the
18.0-mig-web_responsive_company_color
branch
from
112fed8 to
f81eb7e
Compare
OCA-git-bot
added
series:18.0
mod:web_responsive_company_color
tarteo
left a comment
tarteo
left a comment
There was a problem hiding this comment.
Only functional review
Without web_responsive_company_color
With web_responsive_company_color:
| "web_company_color", | ||
| "web_responsive", | ||
| ], | ||
| "data": [], |
There was a problem hiding this comment.
Nitpicking, but I prefer to remove empty keys in the manifest.
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@tarteo your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3428-by-tarteo-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
SirPyTech
force-pushed
the
18.0-mig-web_responsive_company_color
branch
from
f81eb7e to
f884f18
Compare
|
This module has to be a rebel module because it depends on |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@tarteo your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3428-by-tarteo-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Ah okay, I misread :) |
SirPyTech
force-pushed
the
18.0-mig-web_responsive_company_color
branch
from
f884f18 to
172f523
Compare
|
@tarteo now it should work, thanks for your support 🙏 |
|
This PR has the |
|
Awesome thanks! /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
6 participants
Migration of module proposed in PR #3185, it's not a
[MIG]PR because the module has never been merged.I also added a test in the migration commit.
It depends on 2 open PRs:
Since they are both on the same module, they can't be applied both in the CI following https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s) so something will fail; I'll fix it as soon as one of them is merged.