Skip to content

[18.0][FIX] spreadsheet_oca: inherit parent components in SpreadsheetControlPanel#112

Open
nericervin wants to merge 1 commit intoOCA:18.0from
waikiservicios:18.0-fix-controlpanel-dropdown
Open

[18.0][FIX] spreadsheet_oca: inherit parent components in SpreadsheetControlPanel#112
nericervin wants to merge 1 commit intoOCA:18.0from
waikiservicios:18.0-fix-controlpanel-dropdown

Conversation

@nericervin
Copy link
Copy Markdown

Summary

SpreadsheetControlPanel extends ControlPanel but overrides its static components property with only SpreadsheetName, losing Dropdown and DropdownItem that the parent template (web.ControlPanel) uses.

This causes:

OwlError: Cannot find the definition of component "Dropdown"

The error occurs when opening a spreadsheet from certain navigation paths (e.g., from a form view or a custom action), where the parent template's Dropdown component is needed.

Fix

Spread parent components before adding custom ones:

// Before (bug)
SpreadsheetControlPanel.components = {
    SpreadsheetName,
};

// After (fix)  
SpreadsheetControlPanel.components = {
    ...ControlPanel.components,
    SpreadsheetName,
};

This follows the same pattern used for SpreadsheetControlPanel.props which already spreads ControlPanel.props.

Test plan

  • Open a spreadsheet from the kanban view — works before and after
  • Open a spreadsheet from a form view (e.g., linked record) — fails before, works after
  • Edit spreadsheet name in the control panel — works
  • Breadcrumb navigation — works

…lPanel

SpreadsheetControlPanel extends ControlPanel but overrides
its static components property, losing Dropdown and
DropdownItem that the parent template uses.

This causes "Cannot find the definition of component
Dropdown" when opening a spreadsheet from certain
navigation paths (e.g. from a form view).

Fix: spread parent components before adding custom ones.
@pedrobaeza pedrobaeza added this to the 18.0 milestone Apr 13, 2026
@pedrobaeza pedrobaeza requested a review from CarlosRoca13 April 13, 2026 18:34
Copy link
Copy Markdown
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Thanks!

@pedrobaeza pedrobaeza changed the title [FIX] spreadsheet_oca: inherit parent components in SpreadsheetControlPanel [18.0][FIX] spreadsheet_oca: inherit parent components in SpreadsheetControlPanel Apr 14, 2026
@pedrobaeza pedrobaeza requested a review from etobella April 14, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants