[18.0][FIX] spreadsheet_oca: inherit parent components in SpreadsheetControlPanel#112
Open
nericervin wants to merge 1 commit intoOCA:18.0from
Open
[18.0][FIX] spreadsheet_oca: inherit parent components in SpreadsheetControlPanel#112nericervin wants to merge 1 commit intoOCA:18.0from
nericervin wants to merge 1 commit intoOCA:18.0from
Conversation
…lPanel SpreadsheetControlPanel extends ControlPanel but overrides its static components property, losing Dropdown and DropdownItem that the parent template uses. This causes "Cannot find the definition of component Dropdown" when opening a spreadsheet from certain navigation paths (e.g. from a form view). Fix: spread parent components before adding custom ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpreadsheetControlPanelextendsControlPanelbut overrides itsstatic componentsproperty with onlySpreadsheetName, losingDropdownandDropdownItemthat the parent template (web.ControlPanel) uses.This causes:
The error occurs when opening a spreadsheet from certain navigation paths (e.g., from a form view or a custom action), where the parent template's Dropdown component is needed.
Fix
Spread parent components before adding custom ones:
This follows the same pattern used for
SpreadsheetControlPanel.propswhich already spreadsControlPanel.props.Test plan