-
-
Notifications
You must be signed in to change notification settings - Fork 349
[18.0] [FIX] mis_builder: account.account multi company support for Odoo 18 #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
|
Hi @sbidoul, |
f889173 to
995020c
Compare
yajo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review.
Co-authored-by: Stefan Rijnhart <1033124+StefanRijnhart@users.noreply.github.com> Co-authored-by: Geraldo Lopez <5943428+geraldo29@users.noreply.github.com>
995020c to
4100527
Compare
|
Just added translations to "and <nbr_companies_exceeded> more" and translations for other missing terms in es_ES. |
StefanRijnhart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
This PR has the |
sbidoul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The PR is fixes the issue but introduces a change, in the sense that before, there was one detail line per account and company.
I think I more or less know what to do with a first baby step towards configurable account detail expansion.
Marking as request change for now as I'm not convinced yet this is a good default behaviour.
I hope to come to this soon.
|
IMHO the fix should be merged and, later, add that configurability. Otherwise the module explodes in users' hands right now. |
|
@Shide could we apply this PR in PROD? The issue is affecting production clients enviroments. Thank you! |
|
@rafaelbn, unless @sbidoul are making another PR that makes this case better structured, I think we could. @sbidoul, could you ping us to know when the new PR will replace this one? Thanks |
Adapted from #711 and #730.
Limit is set con code and now query_companies it's used to show properly the companies that are being queried.
Also fixed the account code that shows to False if the env.company is not the fetched company data.
Tests are mainly from @StefanRijnhart, but adapted a little bit.
Coauthored with @StefanRijnhart and @geraldo29
MT-11000 @moduon @rafaelbn @StefanRijnhart @geraldo29 @sbidoul @ThiagoMForgeFlow please review if you want 😄