[19.0][MIG] sale_margin_security: Migration to version 19.0 - #285
Open
carlos-lopez-tecnativa wants to merge 26 commits into
Open
[19.0][MIG] sale_margin_security: Migration to version 19.0#285carlos-lopez-tecnativa wants to merge 26 commits into
carlos-lopez-tecnativa wants to merge 26 commits into
Conversation
In sale_margin, when the line already exists, the purchase_price is computed with the product onchange method, so if the user doesn't have the field available in the view it's not going to get the right price. This should be fixed in v13 with the new compute fields possibilities.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-15.0/margin-analysis-15.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-15-0/margin-analysis-15-0-sale_margin_security/
Currently translated at 100.0% (3 of 3 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/es/
Set group_sale_margin_security in all sensible fields.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/
Currently translated at 85.7% (6 of 7 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/es/
Both modules do essentially the same thing: apply a restriction over product costs. Thus, it makes sense to share the same permission groups. This refactor, that depends on OCA/product-attribute#1538, improves the module readme and makes `sale_margin_security` auto-installable addon when `product_cost_security` is found. A migration script is provided to make sure the same users still retain the same permissions. @moduon MT-5158
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/
Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-16.0/margin-analysis-16.0-sale_margin_security Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-16-0/margin-analysis-16-0-sale_margin_security/it/
OCA-git-bot
added
series:19.0
mod:sale_margin_security
1 task
Member
|
/ocabot migration sale_margin_security |
Member
|
CI is red. |
Contributor
Author
Yes, I created a PR to Odoo: odoo/odoo#287257. With this fix, the CI passes locally. I think this is an issue in the framework. I'm waiting to see whether Odoo merges this or how I can reference this PR here. Is it possible to use git-aggregate here, or not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #253
TT64205
@Tecnativa @pedrobaeza @sergio-teruel @dreispt @cormaza could you please review this?