[18.0][FIX] mail_tracking: Retry wizard was empty when reopened - #262
Open
CarlosRoca13 wants to merge 1 commit into
Open
[18.0][FIX] mail_tracking: Retry wizard was empty when reopened#262CarlosRoca13 wants to merge 1 commit into
CarlosRoca13 wants to merge 1 commit into
Conversation
Reopening the resend wizard on a failed message showed no recipients at all, leaving no way to retry the delivery. The wizard deduplicated its own lines with a search over the whole mail.resend.partner table instead of scoping it to the current wizard. Those transient records survive between openings until the vacuum removes them, so the second time the wizard was opened the search matched the records created by the first one and every tracking was skipped.
CarlosRoca13
changed the title
pedrobaeza
approved these changes
Sep 5, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Code review. I wonder if we can reuse existing mail.notification, but this will be maybe more hackish, so let's continue with the creation of a new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening the resend wizard on a failed message showed no recipients at all, leaving no way to retry the delivery.
The wizard deduplicated its own lines with a search over the whole mail.resend.partner table instead of scoping it to the current wizard. Those transient records survive between openings until the vacuum removes them, so the second time the wizard was opened the search matched the records created by the first one and every tracking was skipped.
cc @Tecnativa
ping @pedrobaeza @christian-ramos-tecnativa