[19.0][MIG] edi_account_core_oca - #239
Conversation
|
This PR has the |
etobella
left a comment
etobella
left a comment
There was a problem hiding this comment.
@JordiMForgeFlow as we are on a new migration, I think we should rename this module as edi_account_oca, the original one is not required anymore.
Can you handle the merge on openupgrade?
| @@ -0,0 +1,10 @@ | |||
| def pre_init_hook(env): | |||
|
@etobella then I assume we also have to merge the listeners added in #265 to this one right? @JasminSForgeFlow could you attend the changes when possible? |
|
Wait! I assumed that the other one had no code inside, if it has, we should not merge them, as this module should never require listeners, components or queue. maybe the right new should be "edi_account_listener_oca" and "edi_account_oca", however, I think it doesn't make sense to do it now. |
|
Exactly, the edi_account_oca is depending on component to add the listeners, just like edi_stock_oca or edi_purchase_oca. For me it is fine to keep it as it is then. |
|
For me the names could be improved to avoid mistakes.... |
|
Hmm do we really need 2 modules? |
MiquelRForgeFlow
left a comment
MiquelRForgeFlow
left a comment
There was a problem hiding this comment.
@JasminSForgeFlow could you rebase?
…een edi and account without components
Currently translated at 100.0% (20 of 20 strings) Translation: edi-framework-18.0/edi-framework-18.0-edi_account_core_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_account_core_oca/it/
71a7c92 to
b6de744
Compare
Done, Thanks |
OCA-git-bot
added
series:19.0
mod:edi_account_core_oca
There was a problem hiding this comment.
Hmm do we really need 2 modules? It's probably time to align over a call on what we want to do once for all. IMO we should finish #232 first and agree on a common way to handle events w/o components otherwise we will always have an half backed solution in the core and 2 ways to things everywhere.
Still waiting for an answer ;)
Good occasion to discuss: OCA days ;)
10 participants
Standard Migration
@ForgeFlow