Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.vscode/launch.jsonas JSONC withjsonc-parserinstead of stripping comments with a regex//, such asserverReadyAction.patternvalues with URLsReproduce
Current
maincan fail to parse a valid VS Codelaunch.jsonlike this:{ // VS Code accepts comments in launch.json "version": "0.2.0", "configurations": [ { "name": "Debug App", "type": "pwa-node", "request": "launch", "serverReadyAction": { "pattern": "Local:.*(https?://localhost:\\d+)", "action": "startDebugging", "name": "Launch Chrome" } } ] }The previous implementation removes comments with a regex before calling
JSON.parse. That also strips the//insidehttps?://..., corrupts the string, and causesget_debugger_configurationsto reject a file that VS Code itself accepts.Validation
npm run buildinmcp-serverVSCODE_WORKSPACE_PATHto a workspace containingserverReadyAction.pattern: "Local:.*(https?://localhost:\\d+)"getDebuggerConfigurationsToolstatus: "success"and the expected configurations for thatlaunch.jsonmainand reproduced the existing parse failure from the old regex-based parser