Repository navigation
Release 0.12.0.0: reclaim-nars, and a narinfo refused without its NAR - #86
Merged
Merged
Conversation
Dates the changelog section, removes its fragments and bumps the version. Major bump: the exports only grow, but cacheApp now refuses a narinfo it used to accept (no stored NAR, no FileHash or FileSize, or a URL not under nar/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts 0.12.0.0 from main: the two
changelog.d/fragments are assembled under a dated version heading and removed, andnova-cache.cabalmoves to 0.12.0.0. The publish workflow refuses to upload unless the top section ofCHANGELOG.mdis that version, dated.Why a major version
The exports only grow:
NovaCache.Reclaimis new, andNovaCache.ServerandNovaCache.Storegain names without losing any. ButcacheAppnow answers 400 where it answered 200, for a narinfo with no stored NAR, with noFileSizeorFileHash, or with aURLnot undernar/. The PVP's numbered rules speak to types, and its FAQ treats compatibility as semantic, so this is a major bump. nova-nix does not importNovaCache.Server; its< 0.12bound rises in its own repository.Changelog corrections
Each fragment was written when its PR merged. Checked against upstream at 2.24.9 and against warp's changelog:
addToStoreCommonskips a NAR whose file exists (if (repair || !fileExists(narInfo->url))), so a wrong file under that name goes on refusing the narinfo. The entry now says so.URLnot undernar/was implied. It is now stated, with upstream's reader accepting one and itsBinaryCacheStorenever writing one.Checks
CHANGELOG.md, the version and the fragments are all this PR changes. CI runs the code as merged at3758ca1, which also passes on main.CHANGELOG.mdornova-cache.cabal.