Repository navigation
Toolchain: advance the index-state, which moves warp to 3.4.19 - #85
Merged
Merged
Conversation
The pin held warp at 3.4.15, and the server is deployed from this pin. 3.4.17 makes a chunked body cut short by the end of input an error, and refuses a request framing warp and a proxy could read differently. The test suite's QuickCheck cap rises to admit 2.19, which the new index resolves: with the old cap, cabal test finds no component it can build.
Without --enable-tests a test stanza is only a preference. The solver settles the library's goals first, and when the stanza then conflicts with them it drops the stanza rather than backjump into them: tagged 0.9 is newest for the library, aeson through wai-extra needs an older one, and the job stops with no plan for a test suite that has one. Asking for tests makes the stanza a goal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cabal.projectheld the index at 2026-08-20, so the server, which the deploy job builds from this pin, ran warp 3.4.15. warp 3.4.17 changes two things that matter here:PUT /nar/<file>relied on the narinfo check to catch this.Transfer-EncodingandContent-Lengthare read strictly, and a framing warp and a proxy could read differently is refused. The public cache runs behind a proxy.The pin does not travel to consumers, so a Hackage build already resolves a current warp. No changelog entry.
Change
index-statemoves to 2026-11-01T10:08:12Z. warp goes to 3.4.19, with http2 5.4.12, network 3.2.11.0 and time-manager 0.5.2 among 23 packages that move.< 2.19to< 2.20. The new index resolves 2.19. 2.19 adds instances and leavesResultas the suite matches it.--enable-testsnow pass it, and CONTRIBUTING quotes the same command.Why the CI steps change
Without
--enable-testsa test stanza is only a preference. The solver settles the library's goals first, and if the stanza then conflicts it drops the stanza rather than backjump. At this index the library takestagged0.9 whileaeson, throughwai-extrain the test stanza, needs an older one, socabal build nova-cache-bzip2-teststops with "the solver did not find a plan that included the test suites". A plan exists, and--enable-testsfinds it. The matrix step passed only because-f servermakes those packages hard goals.Checks
cabal build all -f server --enable-tests --ghc-options="-Werror", thencabal test -f server --enable-tests --ghc-options="-Werror": pass on macOS arm64, GHC 9.14.1, on warp 3.4.19.actionlint: clean. ASCII only.