Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23" />
<PackageReference Include="SerilogAnalyzer" Version="0.15.0" />
<PackageReference Include="StyleCop.Analyzers.Unstable" Version="1.2.0.556" />
<PackageReference Include="UsingLayoutAnalyser" Version="0.3.0" />
<PackageReference Include="UsingLayoutAnalyser" Version="0.4.0" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion Nota.CodeAnalysis/Nota.CodeAnalysis.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="18.7.23" />
<PackageReference Include="SerilogAnalyzer" Version="0.15.0" />
<PackageReference Include="StyleCop.Analyzers.Unstable" Version="1.2.0.556" />
<PackageReference Include="UsingLayoutAnalyser" Version="0.3.0" />
<PackageReference Include="UsingLayoutAnalyser" Version="0.4.0" />

<!-- Sets Version from the nearest git tag (Directory.Build.props declares the "v" prefix) plus a
height above it, so the package version can never drift from what was actually tagged. Build-
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ Most of this is unsurprising. These are the ones that catch people out:
analyzers stage puts it back, the file on disk never changes, and `dotnet format` reports nothing
to do while `dotnet format --verify-no-changes` exits 2 forever. It is not a diagnostic and no
severity setting reaches it. Rider is unaffected, so this only bites the command line and CI.
- **`UA1002`** is what tells you the above, rather than leaving you to remember it. It reports once
per project on either of those keys being present at any value, and on
`dotnet_diagnostic.SA1210.severity` being turned up to `warning` or `error` - SA1210 has a fix of
its own, and under `dotnet format` its fix and `UA1000`'s undo each other, so the file changes on
every run. It arrived with UsingLayoutAnalyser 0.4.0. Silence from it is not a clean bill of
health: SA1210 left unset is StyleCop's own default, which no analyser can read, so unset is
unknown rather than safe.

## Turning things off

Expand Down