You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before I found this [Android-Scanner-Compat-Library] library, I had rolled my own and allowed my code to set the version of the scanner it wanted to use.
We could ask a user to change the version to something else, and sometimes that fixed things.
Perhaps y'all would think this change is helpful too.
That could easily cause a crash when you set too high SDK version. May I ask, what is the reason for this change? You want to use the older API despite having newer? Internally, in Android, the old, deprecated API is implemented using new one, if you look into it, so I see no reason why that could help.
Unless I am missing something, if sdk it set higher than Build.VERSION_CODES.O it will just use BluetoothLeScannerImplOreo.
I used this in my private code originally developed in the Lollipop/Marshmallow days as an option to test compatibility problems, and figured it could be helpful in the future if there are other changes.
I was not and am not aware of the underlying Android impl.
If it really is moot to set the library to use API 18 on an API 28 device, then feel free to reject this PR...although in final defense, accepting this PR would facilitate providing empirical proof that the setting is moot, and without this ability it would be much harder to prove that the setting is moot.
Feel free to reject, but I considered it a harmless addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before I found this [Android-Scanner-Compat-Library] library, I had rolled my own and allowed my code to set the version of the scanner it wanted to use.
We could ask a user to change the version to something else, and sometimes that fixed things.
Perhaps y'all would think this change is helpful too.