refactor: integrate ActivityPub EmojiReact activity via core filter hooks, extract helpers - #27
Open
julianlam wants to merge 3 commits into
Open
refactor: integrate ActivityPub EmojiReact activity via core filter hooks, extract helpers#27julianlam wants to merge 3 commits into
julianlam wants to merge 3 commits into
Conversation
…ooks, extract helpers - Add filter:activitypub.<method> handlers (emojireact, like, undo, announce) so the plugin claims EmojiReact/Like-with-content activities from the core inbox via the new filter hook seam. - Extract emoji resolution helpers (getEmojiTable, getEmojiAliases, getCharacterIndex, resolveByName, resolveReaction) into helpers.js to keep library.js focused on plugin API and socket handlers. - Remove deprecated `library` field from plugin.json. - Add test suite (test/index.js) covering resolveReaction unit tests, controller-path AP integration, socket handler regression, and edge cases (unknown types, privilege denial, cap exceeded, idempotency). Assisted-by: One of unsloth/Qwen3.6-35B-A3B-GGUF or unsloth/Qwen3.8-27B-GGUF
Assisted-by: One of unsloth/Qwen3.6-35B-A3B-GGUF or unsloth/Qwen3.8-27B-GGUF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
announce) so the plugin claims EmojiReact/Like-with-content activities
from the core inbox via the new filter hook seam.
getCharacterIndex, resolveByName, resolveReaction) into helpers.js
to keep library.js focused on plugin API and socket handlers.
libraryfield from plugin.json.controller-path AP integration, socket handler regression, and edge
cases (unknown types, privilege denial, cap exceeded, idempotency).
Assisted-by: One of unsloth/Qwen3.6-35B-A3B-GGUF or unsloth/Qwen3.8-27B-GGUF