treewide: move PKG_CONFIG env variables into env for structuredAttrs #473942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Sigmanificient
approved these changes
Dec 24, 2025
Member
Sigmanificient
left a comment
Sigmanificient
left a comment
There was a problem hiding this comment.
I found a bunch of other packages that could receive the same treatment 👀
Lyndeno
approved these changes
Dec 24, 2025
nixpkgs-ci
bot
added
12.approvals: 2
Member
|
@SFrijters I made this set of patches that includes fixes for more packages: pkg_config_var_fixes.patch Would you be willing to apply them into your pr? ( |
Member
Author
|
@Sigmanificient Thanks! I did just a fairly minimal grep for things I actually ran into, but it's nice to cover more at once. |
nixpkgs-ci
bot
added
6.topic: pantheon
This comment was marked as resolved.
This comment was marked as resolved.
SFrijters
force-pushed
the
pkg-config-polkit-structuredattrs
branch
from
ec065a9 to
20cddd8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sigmanificient
approved these changes
Dec 25, 2025
Member
Author
|
I'm almost able to do a full rebuild of my desktop, you might be able to find fixes for your build in my other PRs. EDIT: Also "fun" is no longer the word I would choose, haha. |
SigmaSquadron
approved these changes
Dec 27, 2025
Contributor
SigmaSquadron
left a comment
SigmaSquadron
left a comment
There was a problem hiding this comment.
Thank you for all the work w.r.t. structuredAttrs!
nixpkgs-ci
bot
added
12.approvals: 3+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.