perf: use CompositePrimaryKey to avoid redundant indexes
#701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fricklerhandwerk
force-pushed
the
rename-suggestions-model
branch
from
1c64eba to
3a481be
Compare
fricklerhandwerk
force-pushed
the
rename-suggestions-model
branch
2 times, most recently
from
a9e40be to
bce7f21
Compare
fricklerhandwerk
force-pushed
the
rename-suggestions-model
branch
3 times, most recently
from
2887043 to
c641a00
Compare
Needed for `CompositePrimaryKey` in order to save some space on bloated indexes. The additional changes address breaking changes to APIs between Django 4 to Django 5.
fricklerhandwerk
force-pushed
the
rename-suggestions-model
branch
from
c641a00 to
2eea058
Compare
This way we don't need the unused `id` index of the junction table, nor the one for `nixderivation_id`, since that's now covered by the composite primary key's first element. Leaving the `nixderivationoutput_id`, since we still want to obtain reverse dependencies in the fugure.
fricklerhandwerk
force-pushed
the
rename-suggestions-model
branch
from
2eea058 to
86daaaa
Compare
Erethon
approved these changes
Jan 9, 2026
Collaborator
Erethon
left a comment
Erethon
left a comment
There was a problem hiding this comment.
LGTM as far as I understand. I'm running the create index concurrently part on the production instance right now, this shouldn't be merged to the production branch until the index creation has finished running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #661