allow for custom class, auto-size icons#2
Open
routinet wants to merge 2 commits intoNinjaForge:masterfrom
Open
allow for custom class, auto-size icons#2routinet wants to merge 2 commits intoNinjaForge:masterfrom
routinet wants to merge 2 commits intoNinjaForge:masterfrom
Conversation
Included moduleclass_sfx in parent container (previously ignored). Adds module-specific class to parent container only if included CSS is enabled. Added ability for icons to auto-size by setting icon width/height to 0.
Modified code to build <li> elements without whitespace. Cleaned up tabbing in code for readability. Added default fall-through for icon_orientation detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Included moduleclass_sfx in parent container (previously ignored). Adds
module-specific class to parent container only if included CSS is
enabled. Added ability for icons to auto-size by setting icon
width/height to 0.