Skip to content

fix: Changed order of escape to prevent RCE #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yasha-ops wants to merge 2 commits into
base: develop
Choose a base branch
from
+4 −7
Open

fix: Changed order of escape to prevent RCE #5498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46bf327
fix: Changed order of escape to prevent RCE
Apr 19, 2026
6629abe
Use fs module for credential file operations
Yasha-ops Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions backend/setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import certificateModel from "./models/certificate.js";
import settingModel from "./models/setting.js";
import userModel from "./models/user.js";
import userPermissionModel from "./models/user_permission.js";
import fs from "fs";

export const isSetup = async () => {
const row = await userModel.query().select("id").where("is_deleted", 0).first();
Expand Down Expand Up @@ -120,18 +121,14 @@ const setupCertbotPlugins = async () => {

// Make sure credentials file exists
const credentials_loc = `/etc/letsencrypt/credentials/credentials-${certificate.id}`;
// Escape single quotes and backslashes
if (typeof certificate.meta.dns_provider_credentials === "string") {
const escapedCredentials = certificate.meta.dns_provider_credentials
.replaceAll("'", "\\'")
.replaceAll("\\", "\\\\");
const credentials_cmd = `[ -f '${credentials_loc}' ] || { mkdir -p /etc/letsencrypt/credentials 2> /dev/null; echo '${escapedCredentials}' > '${credentials_loc}' && chmod 600 '${credentials_loc}'; }`;
promises.push(utils.exec(credentials_cmd));
promises.push(fs.mkdir("/etc/letsencrypt/credentials", { recursive: true })
.then(() => fs.writeFile(credentials_loc, certificate.meta.dns_provider_credentials, { mode: 0o600, flag: "wx" })));
}
}
return true;
});

await installPlugins(plugins);

if (promises.length) {
Expand Down