Bump certbot-azure-dns version

[fhennig42]

I need the DNS delegation feature from the azure dns plugin which isn't available in the old version. Therefore I suggest updating the lib to the latest stable version.

[fhennig42]

Is there a way to get access to the build logs?
I can build the image on my local machine without issues.
If the PR is not valid, is there a way to update the certbot-dns-azure plugin directly in the container?
I tried with pip install --upgrade but it looks like it gets overwritten after trying to add a cert from the UI with the version specified in the certbot-dns-plugins.json.

[jc21]

The build failed CI due to recent major postgres releases. If you want to rebase now, hopefully it should pass.

[jc21]

In case you missed it, the plugins json file has moved here.

[jc21]

Can you confirm this build is working as expected?

Can we also find another person to confirm this build is working?

[fhennig42]

I just tested it. The build isn't working out of the box. It is necessary to manually set a specific dependency version, since the certbot-azure-dns plugin is not compatible with azure-mgmt-dns in version 9.x.
The workaround I used is described here: terricain/certbot-dns-azure#58 (comment)

There are multiple PRs in the dns plugin repo that would fix that issue:
terricain/certbot-dns-azure#58
terricain/certbot-dns-azure#64
terricain/certbot-dns-azure#59

But it seems none of them has been reviewed yet.

I'm not sure if the project is still maintained, the last change was almost a year ago...

Should I mark this PR here as draft until something happens on the related project?

If someone else wants to apply the workaround:
I did it like this:
docker exec -it --rm <nginx-container> /bin/bash to enter the container, then
source /opt/certbot/bin/activate to enable the certbot venv
then
pip install azure-mgmt-dns==8.2.0 to install the needed version.

[jc21]

You can add your azure-mgmt-dns dependency in this line and lock it to a version.

"dependencies": "azure-mgmt-dns==9.0.0",

[fhennig42]

I added the suggestion and will try it, as soon as the CI build is ready.

[nginxproxymanagerci]

Docker Image for build 7 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-4816

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

[fhennig42]

I tested the new build and can confirm, that it is now working without manual interaction. From my perspective the PR can be merged.