feat: Standardize environment variables for database connection. #4678
+147
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `DB_ENGINE` environment variable, and unify alls `DB_*` redundant environment variables. fixes NginxProxyManager#4677
``` /app/lib/config.js 5:1 error This group of assignments is not aligned align-assignments/align-assignments 14:9 error Missing space before value for key 'host' key-spacing 15:9 error Missing space before value for key 'port' key-spacing 19:9 error Missing space before value for key 'host' key-spacing 20:9 error Missing space before value for key 'port' key-spacing 24:9 error Missing space before value for key 'host' key-spacing 25:9 error Missing space before value for key 'port' key-spacing 30:2 error Missing semicolon semi 58:4 error This group of assignments is not aligned align-assignments/align-assignments 58:62 error Missing semicolon semi 76:4 error This group of assignments is not aligned align-assignments/align-assignments 76:62 error Missing semicolon semi ✖ 12 problems (12 errors, 0 warnings) 12 errors and 0 warnings potentially fixable with the `--fix` option. ```
``` /app/lib/config.js 58:4 error This group of assignments is not aligned align-assignments/align-assignments 76:4 error This group of assignments is not aligned align-assignments/align-assignments ✖ 2 problems (2 errors, 0 warnings) 2 errors and 0 warnings potentially fixable with the `--fix` option. ```
jc21
added
the
requires-verification
|
Docker Image for build 10 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
DB_ENGINEenvironment variable, and unify allsDB_*redundant environment variables.Additional context
The previous method of configuring databases still works, to provide backward compatibility, but priority is given to this proposed approach. In the future (in a major version), the previous method should be removed.
fixes #4677