Repository navigation
fix: handle resource packs and shaders listed among a pack's mods - #25
Merged
Merged
Conversation
The README edit on main left a trailing space (Prettier check fails) and the generated installation page out of date (docs:pages check fails), so CI on main was red.
A real CurseForge export listed Faithful 32x (a resource pack) with its mods; ModShift looked for it under the target's mod loader and reported it as not found. Resource packs and shaders are now looked up under the loaders Modrinth uses for them (minecraft; iris, optifine, canvas, vanilla, per labrinth's validators), installed in resourcepacks/ or shaderpacks/ (also from the CurseForge class id), linked to their own Modrinth page, and never get mod alternatives.
…-packs # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in a real run on a CurseForge export (SkyBlock Enhanced 5.4.1, Fabric 26.2 → 26.3).
Problem
Faithful 32x, a resource pack, is listed in the CurseForge export alongside the mods. ModShift searched for it under the
fabricloader and reported it as "not found". The report also linked it tomodrinth.com/mod/…, and a migrated pack would have put it inmods/.Fix
The behaviour now follows the Modrinth project type (
project_type):minecraftloader. Shaders are searched underiris,optifine,canvasandvanilla. These are the loaders accepted by Modrinth's own validators (labrinthvalidate/resourcepack.rsandvalidate/shader.rs).resourcepacks/orshaderpacks/.classId(12 = resource pack, 6552 = shader). These values are checked in Prism Launcher (FlameAPI.cpp) and packwiz (curseforge.go).modrinth.com/resourcepack/….Tests reproduce the case: a resource pack with a target version, one without (no search requests sent), and CurseForge classes 12 / 6552 / 6. CHANGELOG updated.
Checks
lint, format, typecheck, build and the docs diff are clean. 442 tests pass.
This PR includes the README commit from the "docs: format the README install section" PR, so its CI isn't held up by
main. That commit becomes a no-op once that PR is merged.Generated by Claude Code