Repository navigation
fix: explain updates that keep the same version number - #24
Merged
Merged
Conversation
Real packs showed "3.3.6 -> 3.3.6" as an update for Packet Fixer, Stella, SkyOcean and others: their authors publish a separate file per Minecraft version under the same version number. The reason now says so, instead of looking like an error.
The README edit on main left a trailing space (Prettier check fails) and the generated installation page out of date (docs:pages check fails), so CI on main was red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in a real run on a CurseForge pack (SkyBlock Enhanced 5.4.1, Fabric 26.2 → 26.3).
Problem
Packet Fixer, Entity Culling, 3D Skin Layers, Stella, SkyOcean, Custom Scoreboard and others showed up as "update found" with
3.3.6 → 3.3.6. This is correct: their authors publish a separate file per Minecraft version under the same version number. But without an explanation it looks like a mistake.Fix
When the target file is different but the version number is the same, the reason now reads: "Same version number, file built for Minecraft 26.3." It appears in the Notes column and in every report.
A test reproduces the case, and the CHANGELOG is updated.
Checks
lint, typecheck and 441 tests pass. Formatting on the base branch fails because of the README; that is fixed in the PR "docs: format the README install section".
Generated by Claude Code