Repository navigation
fix: require a digit in loader versions - #21
Merged
Merged
Conversation
A real run accepted "--loader-version X.Y.Z" (another placeholder copied from an example) because it looks like a version, and wrote an unusable pack. Every real loader version contains a digit, so values without one (X.Y.Z, latest) are now rejected before any request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20, found during a real run.
Problem
migrate --loader-version X.Y.Z, a placeholder copied from an example, was accepted because it has the form of a version. ModShift then wrote a.mrpackthat launchers can't use.Fix
Every real loader version contains a digit, so a value without one (
X.Y.Z,latest) is now rejected before any request is sent.The check applies to
--loader-version,target.loaderVersionand the web UI. Tests and CHANGELOG are updated.Checks
lint, format, typecheck, build and the docs diff are clean. 440 tests pass.
Generated by Claude Code