Skip to content

Render bios as safe Markdown - #687

Merged
jbampton merged 1 commit into
NextCommunity:mainfrom
shyama-05:fix/safe-markdown-bios
Nov 18, 2026
Merged

jbampton merged 1 commit into
NextCommunity:mainfrom
shyama-05:fix/safe-markdown-bios

Conversation

@shyama-05

Copy link
Copy Markdown
Member

Fixes #403

Summary

  • Render user bios as Markdown with raw HTML disabled.
  • Convert Ken Horlador’s bio from HTML tags to Markdown.
  • Keep homepage bio excerpts as plain text.
  • Add markdown-it and update the lockfile.

Validation

  • npm.cmd run eleventy:build — passed; 81 pages generated.

Apologies for the delay in submitting this PR, and thank you for assigning me to the issue.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​markdown-it@​15.0.31001008790100

View full report

@deepsource-io

deepsource-io Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 6bed194...ed23bdc on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Nov 16, 2026 2:46p.m. Review ↗
Secrets Nov 16, 2026 2:46p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@shyama-05

Copy link
Copy Markdown
Member Author

Hi @jbampton and @BaseMax,

I've submitted PR #687 for issue #403. The build validation has passed successfully.

Could you please review my changes when you get a chance? Thank you for assigning me this issue!

@jbampton jbampton self-assigned this Nov 18, 2026
@jbampton jbampton moved this to In progress in Next Nov 18, 2026
@jbampton jbampton added this to the Hackfest 2026 milestone Nov 18, 2026
@jbampton
jbampton requested a lite review from Copilot November 18, 2026 18:49
@jbampton jbampton moved this from In progress to Review in progress in Next Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the change’s safe Markdown rendering and plain-text excerpt handling address the stated functionality.

No open issues 🎉

What changed in this PR

This pull request adds safe Markdown rendering for user bios with raw HTML disabled, preserves plain-text homepage excerpts, converts Ken Horlador’s bio to Markdown, and adds the markdown-it dependency.

Changes:

  • Registers a Markdown-It filter configured to disable raw HTML.
  • Renders full bios as safe Markdown and strips formatting from homepage excerpts.
  • Updates Ken Horlador’s bio and dependency lockfile.
File Description
src/​users/​kenhorlador.yaml Converts Ken Horlador’s bio formatting and links from HTML to Markdown syntax.
src/​index.njk Processes homepage bio excerpts into plain text after Markdown rendering.
src/​_includes/​bio.njk Renders full user bios as safe Markdown-generated HTML.
package.json Adds markdown-it as a dependency.
package-lock.json Records markdown-it and its transitive dependency updates.
.eleventy.js Registers the Markdown-It filter with raw HTML disabled.

Review effort: Lite

@jbampton jbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🏂

@github-project-automation github-project-automation Bot moved this from Review in progress to Reviewer approved in Next Nov 18, 2026
@jbampton
jbampton merged commit 58f8fdb into NextCommunity:main Nov 18, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Next Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

use of HTML tags like inside a YAML

3 participants