Skip to content

Dev #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhishek-nexgen-dev merged 2 commits into from
May 17, 2026
Merged

Dev #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8a4c5b
feat: update webhook management with new permissions field and improv…
abhishek-nexgen-dev May 17, 2026
59c568e
fix: update webhook URL in tests for consistency and accuracy
abhishek-nexgen-dev May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/features/SideBar/v1/Section/SideBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import { useTheme } from "@/theme";
import { ThemeToggle } from "@/Component/ui/ThemeToggle";

import SideBarLink from "../Components/SideBarLink";
import { dashboardData } from "@/features/Member/v1/mock/dashboardData";

import useAuthStore from "@/features/Auth/v1/Store/Auth.Store";
import { useEffect } from "react";

import useOrganizationStore from "@/features/Auth/v1/Store/Organization.Store";

const SideBar = () => {
Expand Down
2 changes: 1 addition & 1 deletion src/features/Tasks/v1/pages/TaskDetailPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ export default function TaskDetailPage() {
onConfirm={() => void handleDelete()}
onCancel={() => setShowDeleteModal(false)}
isLoading={deleteTask.isPending}
danger

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The danger prop was removed but not replaced with variant="danger". Based on the refactoring seen in WebhookListPage.tsx, it appears the ConfirmModal component now expects a variant prop. Removing this without replacement will likely cause the delete button to lose its destructive visual styling (e.g., red color).

Suggested change
variant="danger"

/>

<ToastContainer toasts={toasts} onDismiss={dismiss} />
Expand Down
2 changes: 1 addition & 1 deletion src/features/Tasks/v1/pages/TaskManagementPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export default function TaskManagementPage() {
onConfirm={() => void handleDelete()}
onCancel={() => setTaskToDelete(null)}
isLoading={deleteTask.isPending}
danger

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the change in TaskDetailPage.tsx, the danger prop was removed without being replaced by variant="danger". This regression should be fixed to maintain visual consistency for destructive actions.

Suggested change
variant="danger"

/>

<ToastContainer toasts={toasts} onDismiss={dismiss} />
Expand Down
1 change: 1 addition & 0 deletions src/features/Webhooks/v1/Webhook.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export interface UpdateWebhookPayload {
events?: WebhookEvent[];
status?: WebhookStatus;
secret?: string;
permissions?: string[];
}

export interface WebhookFilters {
Expand Down
Loading
Loading