Skip to content

Check spike waveforms with t_start and t_stop in rawio compliance tests - #1974

Open
ptlnextdoor wants to merge 1 commit into
NeuralEnsemble:masterfrom
ptlnextdoor:fix/oss-neo-1960
Open

ptlnextdoor wants to merge 1 commit into
NeuralEnsemble:masterfrom
ptlnextdoor:fix/oss-neo-1960

Conversation

@ptlnextdoor

Copy link
Copy Markdown

Fixes #1960

What was missing

read_spike_times in rawio_compliance.py reads one spike with forced t_start and t_stop and compares it to the full read. read_spike_waveforms only read with t_start=None and t_stop=None, so the time-limited waveform path was not tested for any reader.

What changed

  • read_spike_waveforms now also reads one spike (the second one) with forced limits, in channels with more than 3 spikes. It checks that one waveform comes back, with the same shape per waveform, and equal to the matching waveform of the full read.
  • ExampleRawIO failed the new check: it generated waveforms from a fixed random seed for the spikes in the range only, so a spike got different waveforms depending on the range. It now generates the waveforms of all spikes and keeps those inside the range.

How it was tested

  • The new check fails on master for ExampleRawIO and passes after the change.
  • pytest neo/test/rawiotest/test_examplerawio.py neo/test/iotest/test_exampleio.py: 11 passed. black --check is clean.
  • I could not run the other rawio tests. gin.g-node.org (the test data host) is unreachable from my environment, so the new check is not verified against other readers. CI will show whether any other reader fails it.

AI disclosure: this PR was prepared with AI assistance (Claude, Anthropic).

…e tests

read_spike_waveforms only read with t_start=None and t_stop=None. Now it also reads one spike by forcing limits and compares it to the full read, as read_spike_times does. ExampleRawIO returned different waveforms for a spike depending on the time range, so it now keeps the waveforms of the spikes inside the range.
Copilot AI balanced review requested due to automatic review settings November 17, 2026 05:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check spike waveforms read with t_start and t_stop in the rawio compliance tests

2 participants