Repository navigation
Conversation
Author
|
The documentation retry has finished: build 36000315 fails in the unchanged The earlier build was terminated by Read the Docs' time limit. The same-base documentation retry for #1972 now passes. No documentation, download, or build configuration was changed in this PR. Could someone with access to the Read the Docs project or the GIN dataset check the example-data download from the builder? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A signal chunk ending at the last sample of a Plexon block can replace that block with zeros, including during a default full-signal read. When the right border is zero,
data[:-border]becomesdata[:0]and drops the block.Only trim the right border when it is positive. The regression tests cover full reads, reads within the last block, and chunks ending inside or between blocks. These use synthetic equal-sized blocks; this has not been tested on a real
.plxrecording.Validation:
pytest neo/test/rawiotest/test_plexonrawio.py::TestPlexonAnalogSignalChunk— 2 passed. The end-of-signal test fails on the base code.