Skip to content

Keep the last Plexon signal block when a read reaches its end - #1971

Open
evadiva3 wants to merge 2 commits into
NeuralEnsemble:masterfrom
evadiva3:fix/neo-2-plexon-last-block-read-as-zeros
Open

evadiva3 wants to merge 2 commits into
NeuralEnsemble:masterfrom
evadiva3:fix/neo-2-plexon-last-block-read-as-zeros

Conversation

@evadiva3

Copy link
Copy Markdown

A signal chunk ending at the last sample of a Plexon block can replace that block with zeros, including during a default full-signal read. When the right border is zero, data[:-border] becomes data[:0] and drops the block.

Only trim the right border when it is positive. The regression tests cover full reads, reads within the last block, and chunks ending inside or between blocks. These use synthetic equal-sized blocks; this has not been tested on a real .plx recording.

Validation: pytest neo/test/rawiotest/test_plexonrawio.py::TestPlexonAnalogSignalChunk — 2 passed. The end-of-signal test fails on the base code.

@evadiva3

Copy link
Copy Markdown
Author

The documentation retry has finished: build 36000315 fails in the unchanged doc/source/rawio.rst example-data download. urllib.request.urlretrieve receives HTTP Error 403: Forbidden while retrieving the GIN example recordings, and the IPython Sphinx directive then aborts the build.

The earlier build was terminated by Read the Docs' time limit. The same-base documentation retry for #1972 now passes. No documentation, download, or build configuration was changed in this PR.

Could someone with access to the Read the Docs project or the GIN dataset check the example-data download from the builder?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant