Add linting to the CI setup, using ruff#1857
Open
apdavison wants to merge 1 commit into
Open
Conversation
For now the setup is quite forgiving, but we can toughen it up later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve overall code quality, I suggest adding a linter to the CI setup. I've gone with ruff, because I've had good experiences with it (in particular, it is fast), but I'm open to consider a different linter. (Note that ruff also does formatting, it's a drop-in replacement for black)
For now the setup is quite forgiving, but we can toughen it up later.
The CI job first tests there are no regressions in code quality, then produces a report on things that could be improved (linter warnings and errors). As we gradually fix these, the rules can be made stricter.