Update echo reader settings handling #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor update_settings to handle dynamic field changes and determine if a restart is needed based on new settings.
| "Restart requested due to changes in: %s", | ||
| ", ".join(sorted(restart_fields & changed_fields)), | ||
| ) | ||
| self._restart_event.set() # Signal restart |
Collaborator
There was a problem hiding this comment.
I guess what you are trying to do here is just make sure we only update the connection if the relevant settings change?
Could it be simplified like this:
restart_needed = (
self.settings is None or \
any([
getattr(self.settings, k) != getattr(new_settings, k)
for k in restart_fields
])
)
self.settings = new_settings
if restart_needed:
self._restart_event.set()
| self.settings = new_settings | ||
| else: | ||
| for key, value in new_values.items(): | ||
| setattr(self.settings, key, value) |
Collaborator
There was a problem hiding this comment.
Why not just overwrite the settings object if you are going to overwrite all of it's values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.