test(smoke): smoke test in rust - #689
Conversation
|
2 CodeQL (go) failed becauses this PR remove all golang code in the repo, so there is no golang code for them to scan |
emlautarom1
left a comment
There was a problem hiding this comment.
Generally LGTM, I would change the way we're enabling/disabling tests by leveraging different feature flags rather than (ab)using ignored tests.
The flake.nix was still listing go packages (go, gopls and delve). I've pushed an extra comit that removes them and also regenerates the lockfile.
There was a problem hiding this comment.
LGTM, but before merging:
Lines 29 to 33 in ab044ac
The pre-push hook is still using --all-features meaning that smoke tests are included. Drop that or limit it to --features integration (integration tests are actually quite fast).
|
Also could you add a pluto/crates/test-compose/src/lock.rs Line 145 in ab044ac Something like #702 wires the quic feature, and since the harness runs nodes with |
No description provided.