Skip to content

test(smoke): smoke test in rust - #689

Merged
iamquang95 merged 13 commits into
mainfrom
feat/fix-597
Sep 18, 2026
Merged

iamquang95 merged 13 commits into
mainfrom
feat/fix-597

Conversation

@iamquang95

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread .github/workflows/smoke-tests.yml Fixed
Comment thread .github/workflows/smoke-tests.yml Fixed
Comment thread .github/workflows/smoke-tests.yml Fixed
@iamquang95

Copy link
Copy Markdown
Collaborator Author

2 CodeQL (go) failed becauses this PR remove all golang code in the repo, so there is no golang code for them to scan

@iamquang95
iamquang95 marked this pull request as ready for review September 9, 2026 08:02
@iamquang95
iamquang95 marked this pull request as draft September 9, 2026 11:06
@iamquang95
iamquang95 marked this pull request as ready for review September 11, 2026 10:09
@emlautarom1 emlautarom1 linked an issue Sep 11, 2026 that may be closed by this pull request

@emlautarom1 emlautarom1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, I would change the way we're enabling/disabling tests by leveraging different feature flags rather than (ab)using ignored tests.

The flake.nix was still listing go packages (go, gopls and delve). I've pushed an extra comit that removes them and also regenerates the lockfile.

Comment thread crates/test-compose/tests/smoke.rs Outdated
Comment thread crates/test-compose/README.md Outdated
Comment thread crates/test-compose/src/process.rs
Comment thread crates/test-compose/README.md Outdated
Comment thread .gitignore

@emlautarom1 emlautarom1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before merging:

pluto/.githooks/pre-push

Lines 29 to 33 in ab044ac

# Tests
if ! cargo test --locked --workspace --all-features; then
echo "❌ Test failures detected"
exit 1
fi

The pre-push hook is still using --all-features meaning that smoke tests are included. Drop that or limit it to --features integration (integration tests are actually quite fast).

@emlautarom1

Copy link
Copy Markdown
Collaborator

Also could you add a p2p-udp-address entry next to p2p-tcp-address in the common node flags:

Kv::new("p2p-tcp-address", "0.0.0.0:3610"),

Something like Kv::new("p2p-udp-address", "0.0.0.0:3630") should suffice.

#702 wires the quic feature, and since the harness runs nodes with --feature-set=alpha, every node becomes a QUIC-type node once it lands; without a UDP address they install the transport but never listen on it, so the smoke tests never see an actual TCP to QUIC upgrade. With the address set up, all_pluto and mixed_2_charon_2_pluto run the upgrade in both directions. It will show up in the Pluto's logs and as p2p_peer_connection_types{protocol="quic"} on both implementations. The relay already gets 0.0.0.0:3630, so the same port works for nodes. The golden files under testdata/ will need regenerating though.

@iamquang95
iamquang95 merged commit 99197f5 into main Sep 18, 2026
14 of 16 checks passed
@iamquang95
iamquang95 deleted the feat/fix-597 branch September 18, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port the compose smoke harness to Rust

4 participants