Add a metric to track "Wrong key returned" errors #108
+33
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds "wrongKeyReturned" as a metric and increments it everytime we see it in action. This change was added as we noticed some of these error messages in the logs, and we'd like to track the frequence of these errors. Note that even prior to this change, we did not return the wrong key back to the calling application but instead count it as a miss.
smukil
commented
Apr 20, 2021
evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
Outdated
Show resolved
Hide resolved
arunagrawal84
approved these changes
Apr 20, 2021
Contributor
arunagrawal84
left a comment
arunagrawal84
left a comment
There was a problem hiding this comment.
nit: Consider creating a method to log error, increment and print stack trace.
Contributor
Author
Thanks @arunagrawal84 . Added a new commit to do so. |
tharanga
reviewed
Apr 23, 2021
evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
Outdated
Show resolved
Hide resolved
evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
Outdated
Show resolved
Hide resolved
evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
Outdated
Show resolved
Hide resolved
evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
Outdated
Show resolved
Hide resolved
evcache-core/src/main/java/net/spy/memcached/EVCacheMemcachedClient.java
Outdated
Show resolved
Hide resolved
- Better logging to catch if returned key is from a different host - Make sure stack trace goes to logs instead of stdout - Naming nits addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds "wrongKeyReturned" as a metric and increments it
everytime we see it in action.
This change was added as we noticed some of these error messages in
the logs, and we'd like to track the frequence of these errors.
Note that even prior to this change, we did not return the wrong key
back to the calling application but instead count it as a miss.