You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
for the 1st and 2nd style issues, it can be check in index, and for the 3rd, Y add a draft for the purposes in /drafts/jlledo/index-demo /drafts/jlledo/rainbow-demo
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.
The following functionalities have been tested on this ticket:
Enable colours settings on components background (ex: Social media cards) -> Working as expected
Enable colours settings on (Cards) components for titles, subtitles and body text to white when background colours are medium or dark -> Working as expected
Darkening Filter -> When the background used in this component is a photo, the 110% brightness makes the texts unreadable and the images do not look good. In addition, this component is often used on the website with different colours, so the change in brightness affects them differently depending on the colour used. When hovering over the component, it looks even worse.
Please find attached some of the pages where the affected component is used and you can see the behaviour, on the left side the page in production and on the right side how it looks with the new changes in the branch.
As we have discussed on the slack channel, by applying the same component on photos and colours it will work on colours but on photos it will look too bright and the text will not be legible, we should apply one solution for colours (which is the new brightness that is being developed) and create a new flavour for images, so they look correctly
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.
@tomasznetcentric please, if you think this PR is ready, merge it for me. thanks
I checked the pr code wise. But yes maybe I miss some context here. Will setup a alignment for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for the 1st and 2nd style issues, it can be check in index, and for the 3rd, Y add a draft for the purposes in
/drafts/jlledo/index-demo
/drafts/jlledo/rainbow-demo
Fix #285
Test URLs: