Enforce basket ownership in GET /rest/basket/:id to fix IDOR#4
Open
emrazik wants to merge 1 commit into
Open
Conversation
GET /rest/basket/:id accepted any basket ID without verifying the authenticated user owned it, allowing any logged-in user to read another user's basket contents by incrementing the ID. Add an ownership check against user.bid (the basket ID encoded in the JWT at login) and return 403 if it doesn't match the requested ID. Remove the now-unused challenge-detection imports. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
NetSPI Finding #1048219782 — Inadequate Authorization Controls (IDOR) | High
GET /rest/basket/:idwas protected byisAuthorized()(user must be logged in) but performed no ownership check. Any authenticated user could read any other user's basket — including their selected products and quantities — simply by incrementing the basket ID in the URL.What changed
routes/basket.ts—retrieveBasket()Added an ownership check at the top of the handler. The authenticated user's basket ID (
user.bid, derived from the JWT at login) is compared to the requested:idparameter. If they don't match, the handler returns403 Access deniedbefore any database query is made.Removed the now-unused
challengeUtilsandchallengesimports that were previously used only for detecting the IDOR challenge.Test plan
403200with their basket data🤖 Generated with Claude Code