Skip to content

Conversation

@lindhe
Copy link

@lindhe lindhe commented Jun 28, 2023

Change description

This change explicitly sets the namespace in the commands suggested in the chart's NOTES.txt file, which are rendered upon installation.
Before this change, the namespace was not included so the commands would generally not work without modification.

Did you add unit tests? Why not?

No, this is a trivial change and a change to what basically amounts to documentation, nonetheless.

Does this code need functional testing?

No, but I ran helm install foo --dry-run . to test it first, and it seems to work as intended.

Note: I first had to kubectl apply -f ./crds/tridentorchestrators.yaml to be able to run the helm install command, even with --dry-run. I think there's no way around that, unfortunately.

Is a code review walkthrough needed? why or why not?

Nah, it's a very straight-forward change imo.

Should additional test coverage be executed in addition to pre-merge?

No.

Does this code need a note in the changelog?

No.

Does this code require documentation changes?

No.

Additional Information

I've also bumped the chart version.

@lindhe
Copy link
Author

lindhe commented Jun 29, 2023

I see that the chart version number does not seem to align with the version number available from the chart repo. Does that mean that I should not bump the version number manually? I assume it's done by a CI pipeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant