NAS and Job Feign Client by suryag1201 · Pull Request #7 · NetApp/cloudstack

suryag1201 · 2025-10-16T09:18:23Z

Description

NAS and Job Feign Client with POJOs

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sandeeplocharla · 2025-10-16T09:21:29Z

...ge/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/JobFeignClient.java

+ * @author Administrator
+ *
+ */
+@Lazy


Job is needed while performing most of ontap operations, so, is Lazy needed?

Once this is in use, it will get initialise and next time it will be available so it will not go to initilize phase again so we can use lazy annotation, only SVM and cluster i did not require lazy bcz we need disaggregated and protocol info

sandeeplocharla · 2025-10-16T09:23:25Z

...ge/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/NASFeignClient.java

+    //File Operations
+
+    @RequestMapping(method = RequestMethod.GET, value="/{volume.uuid}/files/{path}")
+    OntapResponse<FileInfo> getFileResponse(URI uri, @RequestHeader("Authorization") String header, @PathVariable(name = "volume.uuid", required = true) String volumeUUID,


I remember seeing OnTapResponse, was this changed?

yes changed to OntapResponse

sandeeplocharla · 2025-10-16T09:25:31Z

...volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/VolumeFeignClient.java

+import org.springframework.web.bind.annotation.RequestMethod;


 @FeignClient(name = "VolumeClient", url = "https://{clusterIP}/api/storage/volumes", configuration = FeignConfiguration.class)


I guess here we can use Lazy

sandeeplocharla · 2025-10-16T09:27:47Z

...storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/ExportRule.java

+    private Integer index = null;
+
+    public enum ProtocolsEnum {
+        any("any"),


Shall we leave them as is? Or shall we have only the ones that we would be supporting?

sandeeplocharla · 2025-10-16T09:28:28Z

...storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/ExportRule.java

+    }
+
+    @Override
+    public int hashCode() {


Could remove this too

sandeeplocharla · 2025-10-16T09:29:29Z

...storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/ExportRule.java

+        return o.toString().replace("\n", "\n    ");
+    }
+
+    public static class ExportClient {


lets put this somewhere in beginning itself, instead at the EOF?

shifted little up

sandeeplocharla · 2025-10-16T09:52:52Z

.../ontap/src/main/java/org/apache/cloudstack/storage/feign/model/request/VolumeRequestDTO.java

Volume.java doesn't have a reference to Aggregate.java, please include it, if we are removing this
Also, can you please see if 'size' could be added?

rajiv-jain-netapp

some minor comments, approving them with this since they are not blocker. pls ensure to take up them in next PR

rajiv-jain-netapp · 2025-10-17T08:28:47Z

...orage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/ExportPolicy.java

+
+  @Override
+  public int hashCode() {
+    return Objects.hash( id, name, rules, svm);


hashcode and equals should use same set of attributes to evaluate the usecase.

sure, will include in next PR

rajiv-jain-netapp · 2025-10-17T08:30:12Z

...storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/ExportRule.java

+    public enum ProtocolsEnum {
+        any("any"),
+
+        nfs("nfs"),


nfs is nfs3 only, do we really need nfs3 separately ?

rajiv-jain-netapp · 2025-10-17T08:31:17Z

...s/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/FileInfo.java

+  }
+
+  @Override
+  public int hashCode() {


…ommits. # This is the 1st commit message: CSTACKEX-25: Basic class structure # This is the commit message #2: Add PrimaryStoragePool base code # This is the commit message #3: CSTACKEX-25: Create Volume code basic code added # This is the commit message #4: CSTACKEX-25: additional logic for Primary storage pool creation # This is the commit message #5: CSTACKEX-29 Cluster, SVM and Aggr Feign Client # This is the commit message #6: CSTACKEX-29 Added License Info # This is the commit message #7: CSTACKEX-29 Resolve Review Comments # This is the commit message #8: CSTACKEX-29 Resolve Style check issues � This is the commit message #9: CSTACKEX-29 Resolve Style check issues � This is the commit message #10: CSTACKEX-29 Resolve Precommits Issues # This is the commit message #11: CSTACKEX-29 Resolve Precommits Issues

# This is the 1st commit message: NFS Cloudstack volume and export policy utils # This is the commit message #2: Licencse add in files # This is the commit message #3: accessgroup create recode # This is the commit message #4: creatacessgroup for NFS impl # This is the commit message #5: storage pool mounting on host # This is the commit message #6: storage pool mounting on host 1 # This is the commit message #7: vm restart issue # This is the commit message #8: vm restart issue 1 # This is the commit message #9: vm restart issue 2 # This is the commit message #10: vm instance creation test1 # This is the commit message #11: vm instance creation test4

Gupta, Surya added 2 commits October 16, 2025 14:42

CSTACKEX-31 NAS and Job Feign Client and POJOs

d46b0b6

CSTACKEX-31 Fixed Checks Issues

2f3b41f

sandeeplocharla reviewed Oct 16, 2025

View reviewed changes

Gupta, Surya added 3 commits October 16, 2025 15:15

CSTACKEX-31 Resolve Review Comments

88bba44

CSTACKEX-31 Resolve Review Comments

5d03aae

CSTACKEX-31 Resolve Review Comments

6a76348

sandeeplocharla reviewed Oct 16, 2025

View reviewed changes

piyush5netapp approved these changes Oct 16, 2025

View reviewed changes

CSTACKEX-31 Added Aggr and size to volume model

535289c

sandeeplocharla approved these changes Oct 16, 2025

View reviewed changes

suryag1201 requested a review from rajiv-jain-netapp October 16, 2025 11:28

Gupta, Surya added 2 commits October 17, 2025 10:44

CSTACKEX-31 Change the export policy endpoint path

558bd19

CSTACKEX-31 Fixed check styles

9380d57

rajiv-jain-netapp approved these changes Oct 17, 2025

View reviewed changes

suryag1201 merged commit c585299 into main Oct 17, 2025
14 of 16 checks passed

		import org.springframework.web.bind.annotation.RequestMethod;


		@FeignClient(name = "VolumeClient", url = "https://{clusterIP}/api/storage/volumes", configuration = FeignConfiguration.class)

Conversation

suryag1201 commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sandeeplocharla Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajiv-jain-netapp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

suryag1201 commented Oct 16, 2025 •

edited

Loading

sandeeplocharla Oct 16, 2025 •

edited

Loading