Cluster, SVM and Aggr Feign Client by suryag1201 · Pull Request #6 · NetApp/cloudstack

suryag1201 · 2025-10-15T03:04:01Z

Description

Added Custer, SVM and Aggr Feign Client interfaces along with respective POJO's

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sandeeplocharla · 2025-10-15T03:53:35Z

...torage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/SvmResponse.java

There's a folder 'response' under 'model', we can shift it there

As discussed, will create one generic ontap response class

sandeeplocharla · 2025-10-15T03:53:55Z

.../volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/AggregateResponse.java

This file can be shifted to model/response

As discussed, will create one generic ontap response class

sandeeplocharla · 2025-10-15T03:59:22Z

.../storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Aggregate.java

Can't we reuse this in VolumeRequestDTO, instead of AggregateDTO?

As discussed, will remove the request DTOs and use the same ontap model with null annotation

sandeeplocharla · 2025-10-15T03:59:35Z

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Svm.java

Can't we reuse this in VolumeRequestDTO, instead of SvmDTO?

sandeeplocharla · 2025-10-15T04:00:40Z

...ume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/AggregateFeignClient.java

+
+import java.net.URI;
+
+@Lazy


To instantiate only when required, we can use this across all the feign clients?

some feign client we need upfront like Cluster, SVM for others we will use @lazy

rajiv-jain-netapp · 2025-10-15T05:08:46Z

.../volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/AggregateResponse.java

+  }
+
+
+  @Override


for response object classes, we need not to have equals, hashcode and testing methods.

removed all responses and created one generic OnTapResponse for all object which has numRecord or records

rajiv-jain-netapp · 2025-10-15T05:11:03Z

...ns/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Cluster.java

+	public void setVersion(ClusterVersion version) {
+		this.version = version;
+	}
+	@ApiModelProperty(value = "")


these annotations were added due to swagger, and currently we need not to have them, lets remove them

removed it and also removed from already added files also

rajiv-jain-netapp · 2025-10-15T05:11:29Z

...ns/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Cluster.java

+		this.disaggregated = disaggregated;
+	}
+	@Override
+	public String toString() {


we can add equals and hashcode using only uuid in this class

rajiv-jain-netapp · 2025-10-15T05:17:05Z

...torage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/SvmResponse.java

+    return this;
+  }
+
+  public SvmResponse addRecordsItem(Svm recordsItem) {


remove this

removed all responses and created one generic OnTapResponse for all object which has numRecord or records

piyush5netapp · 2025-10-15T05:13:41Z

...ns/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/Version.java

@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one


We can rename this class to Version.java as Version class already follows standard format .

piyush5netapp · 2025-10-15T05:17:43Z

...torage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/SvmResponse.java

@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one


Just a thought, can we have class called response.java which accepts generic and we can remove all AggregateResponse etc response objects.

suryag1201 · 2025-10-16T04:37:23Z

...ume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/AggregateFeignClient.java

+public interface AggregateFeignClient {
+
+    @RequestMapping(method=RequestMethod.GET)
+    OnTapResponse<Aggregate> getAggregateResponse(URI baseURL, @RequestHeader("Authorization") String header);


Add the comment for this method

suryag1201 · 2025-10-16T04:37:55Z

...ge/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/SvmFeignClient.java

+public interface SvmFeignClient {
+
+    @RequestMapping(method = RequestMethod.GET)
+    OnTapResponse<Svm> getSvmResponse(URI baseURL, @RequestHeader("Authorization") String header);


same here, add comments

… name

piyush5netapp · 2025-10-16T04:55:33Z

...volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/VolumeFeignClient.java

@@ -34,27 +37,20 @@
 public interface VolumeFeignClient {

    @DeleteMapping("/storage/volumes/{id}")


/api is missing

piyush5netapp · 2025-10-16T04:58:12Z

...ge/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/SvmFeignClient.java

+public interface SvmFeignClient {
+
+    //this method to get all svms and also filtered svms based on query params as a part of URL
+    @RequestMapping(method = RequestMethod.GET)


A general comment which can be taken later. I see somewhere RequestMapping and somewhere GetMapping,PostMapping.We can have same aross all feign client

…ommits. # This is the 1st commit message: CSTACKEX-25: Basic class structure # This is the commit message #2: Add PrimaryStoragePool base code # This is the commit message #3: CSTACKEX-25: Create Volume code basic code added # This is the commit message #4: CSTACKEX-25: additional logic for Primary storage pool creation # This is the commit message #5: CSTACKEX-29 Cluster, SVM and Aggr Feign Client # This is the commit message #6: CSTACKEX-29 Added License Info # This is the commit message #7: CSTACKEX-29 Resolve Review Comments # This is the commit message #8: CSTACKEX-29 Resolve Style check issues � This is the commit message #9: CSTACKEX-29 Resolve Style check issues � This is the commit message #10: CSTACKEX-29 Resolve Precommits Issues # This is the commit message #11: CSTACKEX-29 Resolve Precommits Issues

# This is the 1st commit message: NFS Cloudstack volume and export policy utils # This is the commit message #2: Licencse add in files # This is the commit message #3: accessgroup create recode # This is the commit message #4: creatacessgroup for NFS impl # This is the commit message #5: storage pool mounting on host # This is the commit message #6: storage pool mounting on host 1 # This is the commit message #7: vm restart issue # This is the commit message #8: vm restart issue 1 # This is the commit message #9: vm restart issue 2 # This is the commit message #10: vm instance creation test1 # This is the commit message #11: vm instance creation test4

Gupta, Surya added 3 commits October 14, 2025 22:47

CSTACKEX-29 Cluster, SVM and Aggr Feign Client

951d8ea

CSTACKEX-29 Change the endpoint method name in feign client

85da607

CSTACKEX-29 Make the alignment proper

c35ebc8

suryag1201 self-assigned this Oct 15, 2025

suryag1201 requested review from piyush5netapp, rajiv-jain-netapp and sandeeplocharla October 15, 2025 03:06

CSTACKEX-29 Added License Info

4a42f58

sandeeplocharla reviewed Oct 15, 2025

View reviewed changes

rajiv-jain-netapp reviewed Oct 15, 2025

View reviewed changes

piyush5netapp reviewed Oct 15, 2025

View reviewed changes

Gupta, Surya added 5 commits October 15, 2025 15:25

CSTACKEX-29 Resolve Review Comments

287a8b0

CSTACKEX-29 Remove Component Annotation from datastoredriverclass

5802f44

CSTACKEX-29 Resolve Style check issues

0363ab5

CSTACKEX-29 Resolve ALL Style issues

a74c021

CSTACKEX-29 Resolve Precommits Issues

8de7034

sandeeplocharla approved these changes Oct 16, 2025

View reviewed changes

suryag1201 commented Oct 16, 2025

View reviewed changes

CSTACKEX-29 Added Method comments and change the ontap response class…

9ceeb10

… name

piyush5netapp reviewed Oct 16, 2025

View reviewed changes

rajiv-jain-netapp approved these changes Oct 16, 2025

View reviewed changes

piyush5netapp self-requested a review October 16, 2025 04:59

piyush5netapp approved these changes Oct 16, 2025

View reviewed changes

suryag1201 merged commit f7b837a into main Oct 16, 2025
16 checks passed

		@@ -0,0 +1,130 @@
		/*
		* Licensed to the Apache Software Foundation (ASF) under one

		@@ -0,0 +1,131 @@
		/*
		* Licensed to the Apache Software Foundation (ASF) under one

		@@ -34,27 +37,20 @@
		public interface VolumeFeignClient {

		@DeleteMapping("/storage/volumes/{id}")


		import java.net.URI;

		@Lazy

Conversation

suryag1201 commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suryag1201 Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suryag1201 Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

piyush5netapp Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

suryag1201 commented Oct 15, 2025 •

edited

Loading

suryag1201 Oct 15, 2025 •

edited

Loading

suryag1201 Oct 15, 2025 •

edited

Loading

piyush5netapp Oct 16, 2025 •

edited

Loading