Closed
Conversation
suryag1201
commented
Oct 30, 2025
...ap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java
Outdated
Show resolved
Hide resolved
suryag1201
commented
Oct 30, 2025
...ap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java
Outdated
Show resolved
Hide resolved
suryag1201
commented
Oct 30, 2025
...ap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java
Show resolved
Hide resolved
suryag1201
commented
Oct 30, 2025
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/Utility.java
Outdated
Show resolved
Hide resolved
suryag1201
commented
Oct 30, 2025
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/Utility.java
Outdated
Show resolved
Hide resolved
suryag1201
commented
Oct 31, 2025
| if(ProtocolType.ISCSI.name().equalsIgnoreCase(details.get(Constants.PROTOCOL))) { | ||
| Map<String, String> getCloudStackVolumeMap = new HashMap<>(); | ||
| getCloudStackVolumeMap.put(Constants.NAME, volumeVO.getPath()); | ||
| getCloudStackVolumeMap.put(Constants.SVM_DOT_NAME, svmName); |
Author
There was a problem hiding this comment.
check for wildcard in values
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to attach ONTAP storage pools to clusters/zones and grant access to volumes for iSCSI protocol. The implementation creates initiator groups (igroups) during cluster/zone attachment and enables LUN mapping when granting volume access to hosts.
Key changes:
- Implements access group (igroup) creation and retrieval for SAN storage
- Adds LUN mapping/unmapping operations for volume access control
- Implements
attachClusterandattachZonemethods to create igroups with host initiators - Adds
grantAccessandrevokeAccessimplementations for volume access management
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| Utility.java | Added helper methods for creating access groups, generating igroup names, LUN names, and OS type mapping |
| Constants.java | Added new constants for API endpoints, query parameters, and naming conventions |
| UnifiedSANStrategy.java | Implemented methods for igroup and LUN map operations (create, get, enable/disable logical access) |
| UnifiedNASStrategy.java | Updated method signatures to match interface changes |
| StorageStrategy.java | Modified abstract method signatures to accept Map parameters and added public visibility |
| OntapPrimaryDatastoreProvider.java | Fixed logger import to use correct Log4j interface |
| OntapPrimaryDatastoreLifecycle.java | Implemented cluster/zone attachment logic with igroup creation and host protocol validation |
| SANFeignClient.java | Updated Feign client method signatures for igroup and LUN map operations |
| OntapPrimaryDatastoreDriver.java | Implemented grantAccess and revokeAccess methods for volume access control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/Utility.java
Outdated
Show resolved
Hide resolved
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/Utility.java
Show resolved
Hide resolved
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/Utility.java
Outdated
Show resolved
Hide resolved
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/Utility.java
Show resolved
Hide resolved
...age/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java
Outdated
Show resolved
Hide resolved
...ap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java
Outdated
Show resolved
Hide resolved
...ap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java
Outdated
Show resolved
Hide resolved
...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java
Outdated
Show resolved
Hide resolved
...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java
Outdated
Show resolved
Hide resolved
...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
lets take latest from Sandeep PR
|
|
||
| private void grantAccessForVolume(StoragePoolVO storagePool, VolumeVO volumeVO, Host host) { | ||
| Map<String, String> details = storagePoolDetailsDao.listDetailsKeyPairs(storagePool.getId()); | ||
| StorageStrategy storageStrategy = utils.getStrategyByStoragePoolDetails(details); |
There was a problem hiding this comment.
this method has moved from utility class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CSTACKEX-36 Attach Cluster/Zone and Grant Access
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?